Pedro Gomes
Pedro Gomes
Passing arrays by pointer -> don't https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rr-use-ptr Variables declared at the top of the function -> https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-introduce Using member variables to "pass data" to other methods -> https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Ri-explicit "What are...
[WIP] SU2-specific best practices (carried over from #1487) - Get rid of magic numbers in the code: enums (ongoing work) #1457 (and many others) - Get rid of magic numbers...
For a consistent implementation with SSTm (no tke in stress tensor) the production term should be P = mu_t S^2. Our production term is in no man's land, I'm suggesting...
And a few other changes in constants. I am absolutely fine with that but I do not have bandwidth to update all the regression tests, re-run validation tests, etc.
As we mentioned in the dev meeting where you exposed the problem, the implementation is not good for strongly coupled flows, and I would guess that it is worse for...
Your last figure is for momentum magnitude, I assume that your results with explicit/implicit Euler for single zone are the same?
Using Euler explicit for the turbulence used to result in a crash, I assumed you were using implicit with the same very low CFL, sorry about that. We need to...
Keep it open
You can use paths for the inputs and outputs of the code, e.g. RESTART_FILENAME= ./test/restart.dat or MESH_FILENAME= ../mesh.su2 I think it is much safer if you use paths for inputs...
Try wrapping the path in single quotes `MESH_FILENAME= 'D:\executable22\401_cfd_2d\proj5\mesh.su2'`