Pedro Gomes

Results 133 comments of Pedro Gomes

Thank you for digging into the code. This is one of the obscure features in SU2 that the currently active developers have little knowledge about. I looked around the repo...

Hi @davistib, any news here? If setting up a small example is proving difficult we'll settle for just the code fix :) thanks.

@naveensrinivasan Thank you for the contribution, please reply to Martin's questions so we can get this moving.

Please give this PR a title that better describes the functionality you are introducing. I think I did that for you previous PR

Aside from my last two comments, and the possibility I broke the code :), this looks ready. Is this missing anything, or is it ready to merge?

Have you run that case to convergence before and after and compared the outputs it is computing? If it converges to the same values it's fine.

Hi Ettore, have you tried lowering the 4th order dissipation coefficient? This may be related to how the Laplacians are computed on boundaries.

The logic when computing the Laplacians (used for 4th order dissipation) is that for points on a physical boundary, only other physical boundaries are considered when adding solution differences. I...

Still an important correctness issue in the code.

This is already possible with the python wrapper, see testcases/py_wrapper/flatPlate_unsteady_CHT_FlatPlate.py I am against adding any more "profile files" to SU2.