Pedro Gomes

Results 133 comments of Pedro Gomes

Okay, then allow me to save you guys some time, implement something similar to what we use for the FEA solver. See the use of `element_properties` in CFEASolver.cpp.

https://en.wikipedia.org/wiki/Additive_Schwarz_method How large are the meshes in your examples? I expect convergence will slow down as you go to bigger problems.

You had I comment but I don't see it here. In any case, it's the total time to solution (same residual drop) that I expect will get worse. At constant...

@EvertBunschoten even if the performance isn't great this is a pretty small change so I think we can merge it. Do you have time to wrap it up and add...

We can check for the last "." that is after the last / (if one exists).

But kudos for bringing this up to speed of course. Maybe to start you and other reviewers can try to point out what aspects of this solver we can take...

@Corentinthomee can you add a testcase? otherwise please update AUTHORS.md so we can merge

@Nicola-Fonzi is this something you've seen before?

You are right we fixed that for the Roe scheme at some point, if you have time open a PR please.