rfhub2 icon indicating copy to clipboard operation
rfhub2 copied to clipboard

Switch print logic to logger for CLI

Open MarcinMaciaszek opened this issue 3 years ago • 2 comments

We are using prints for CLI actions, let's move it to the dedicated logger. Once logger would be available we can provide better prints during data import to rfhub2.

MarcinMaciaszek avatar Mar 30 '21 10:03 MarcinMaciaszek

@MaciejWiczk I had a look at it, and it doesn't make sense to use logger for a few messages, let me know if clock echo makes sense. Otherwise, we can close it :-) https://github.com/pbylicki/rfhub2/compare/feature/rfhub2-367-switch-to-logger-in-cli?expand=1

MarcinMaciaszek avatar May 18 '21 19:05 MarcinMaciaszek

@MaciejWiczk I had a look at it, and it doesn't make sense to use logger for a few messages, let me know if clock echo makes sense. Otherwise, we can close it :-) https://github.com/pbylicki/rfhub2/compare/feature/rfhub2-367-switch-to-logger-in-cli?expand=1

I didn't know that click had echo. I like its simplicity :) Could You also bump version when creating PR?

MaciejWiczk avatar May 22 '21 17:05 MaciejWiczk