jupyterlab-sql icon indicating copy to clipboard operation
jupyterlab-sql copied to clipboard

Published 20 hours ago • verified publisher icon pbugnion

Support JupyterLab 2.0

Open jseabold opened this issue 4 years ago • 2 comments

This is going to need another pair of eyes, but I wanted to try out the extension and also learn a little more about jupyterlab development. I never used this when it worked with JupyterLab 1.x, so I'm not quite sure what to expect.

The main changes that are needed to update to 2.x are here. The other changes were to the DataGrid API itself, which AFAICT, changed before the move from phosphor to lumino. I'm more confident than nothing in these changes, glancing over the lumino code and given the test suite passing.

For reference, this is the code for the last supported version of datagrid.

jseabold avatar May 18 '20 13:05 jseabold

Closes #127 #130 #131

jseabold avatar May 18 '20 14:05 jseabold

There appear to be some issues with things like loading feedback. Unclear to me whether they're related to things in this PR yet. Could use another set of eyes until I'm more familiar with the code.

jseabold avatar May 19 '20 19:05 jseabold