diffy icon indicating copy to clipboard operation
diffy copied to clipboard

Front fix memory leak

Open capo999 opened this issue 3 years ago • 1 comments

capo999 avatar Feb 04 '22 15:02 capo999

Overall I love this PR, the problem is that it is too convoluted. I'm not too convinced about the directory layout. I think angular has already a complex layout and separating it into pages/components might make sense for a larger app but is a big change and in the end I'll have to maintain it and I'm not too convinced, also there are only 2 pages so not a big benefit of having this extra dimension.

We can do two things, after I get some clarity on some questions from the comments I can cherry pick the memory leak commits (the first 4 or 5), or you can split this PR into one for the memory leaks and another one for the css and interface changes and leave the directory structure layout out, we can always address that in a separate standalone no-code change directory structure-only PR.

I'd actually make 4 PRs out of this one:

  1. Memory leaks
  2. Add tailwind and remove bootstrap
  3. Add dark mode functionality
  4. Propose a new directory structure

This makes more sense and so much easier to merge and fix one problem at a time.

pbu88 avatar Feb 13 '22 12:02 pbu88