Pat Brisbin

Results 67 comments of Pat Brisbin

Yeah I agree. Looking at the API docs between Create and Update the POST bodies are identical, you would expect the result to be the same too.

There seems to be more functionality that doesn't work for the update vs create: ![](https://files.pbrisbin.com/screenshots/screenshot.678138.png) I don't see the annotations appear in the diff. Unfortunately, I think not seeing the...

Oh, that may actually be our fault. I need to investigate where file/line information is meant to live in a JUnit XML. Our formatter seems to just have it as...

Oh, that's convenient! Here is an example of what it is right now: [golden.xml](https://github.com/freckle/hspec-junit-formatter/blob/main/tests/golden.xml) But we author this formatter, so I can pretty easily add `attributes.{file,line}`, which it looks like...

So you are saying that if we added `file="{file}:{line}"` that would also work? > line numbers are not consistent between different output formats And there isn't any one way to...

Thanks for mentioning me @danielcompton. What we _might_ use a field like `:explanation` for would be the `content.body` issue property, which ultimately ends up rendered by the Book icon on...

> might want one update to aurget that gives a small notice when run that the package isn't currently being maintained any longer This is a good idea, thank you!...

This message was added in 4.7.4. Thanks @glenntanner3.

This code LGTM but I think it should be opt-in behind a flag and config option, it could be surprising to just start happening. WDYT?

That is indeed what I meant. The fact that it is root-owned means this feature would have some complexity, for example downloading to `/tmp` and then `sudo mv`-ing later (as...