grpreg icon indicating copy to clipboard operation
grpreg copied to clipboard

`grpreg` objective function inconsistency

Open SzymonNowakowski opened this issue 2 years ago • 0 comments

There is an inconsistency in documentation and vignettes for grpreg objective function:

  1. Instruction on page 15 defines the objective function as $$Q = \frac{1}{n} * loss + penalty$$
  2. Models vignette defines the objective function as $$Q = \frac{1}{n} * loss + penalty$$
  3. Penalties vignette, however, defines the objective function differently as $$Q = loss + penalty$$

I have tested the results of grpreg with glmnet on some examples and they are the same, so looking at glmnet objective function for Gaussian families I conclude that 1. and 2. are correct. Could you please update the Penalties vignette?

SzymonNowakowski avatar Jun 07 '22 20:06 SzymonNowakowski