composer-service icon indicating copy to clipboard operation
composer-service copied to clipboard

display composer error output in tab (with warning icon)

Open pborreli opened this issue 11 years ago • 7 comments

pborreli avatar Jan 19 '14 00:01 pborreli

Can we then just use the methods of the Process class instead of the callback ?

youbs avatar Jan 19 '14 00:01 youbs

it didn't work when i tried, that's why i used the callback

pborreli avatar Jan 19 '14 00:01 pborreli

What do you mean? we have getOutput() and getError(). The content is basically the same as we have now (it's just full in case of success). The first time I added the "logs" feature I removed the callback and juste used those two methods, (I lost it and then redevelopped it since because I'm dumb), and I didn't see something wrong.

youbs avatar Jan 19 '14 00:01 youbs

Imo, for this case the text could be under the composer update tab (in red) composerupdateerror

pborreli avatar Jan 19 '14 02:01 pborreli

Why not in the "Composer output" tab?

youbs avatar Jan 19 '14 03:01 youbs

yes that's what i meant

pborreli avatar Jan 19 '14 09:01 pborreli

When the errors are shown in a tab the user needs to switch back to the actual input tab... I think it would be better to have errors and input on one screen without the need to switch between them.. (It could additionally be shown in the output tab)

staabm avatar Jan 19 '14 09:01 staabm