pborman
pborman
Some of the errors are legitimate (and should be addressed), but many of them are not helpful, such as all the ones that say: pkg/yang/yang.go:1100:1⚠️ exported method Action.Typedefs should have...
Sadly, I fixed that along with the others, Andrew. I merged a pull request that addressed the format string errors (%s was doubled in a few places) as well as...
The single long comment line has been reformatted. The other results from lll are not helpful. The results from errcheck, goconst, gocyclo, ineffassign, and golint are not helpful. Other errors...
I think it would be appropriate to have a 1.0 and 1.1 version of goyang. Probably create pkg/yang/v1.1, clone the source code there, and keep it with the package name...
Btw, you may want to consider having an augment field and an augments field, if clients use the augment field directly. The augment field would be backwards compatible with 1.0...
The question becomes, in a dial-out service, who is responsible for determining what data is sent. It seems that for dial-out, the information to send would more than likely be...
A collector should not start listening on the port until it is ready so by the fact that the device is able to connect, it should be able to start...
Normally MustParse is only used when initializing global variables (or init functions). Any place else should probably be done with Parse and then check the error. I don't disagree that...
Sorry for the delay in response. This change will create an extra dependency for every package that includes the uuid package. Since uuids have a very fixed form, it would...
Thank you for pointing this out. Yes, this is a bug and should be fixed. Would be happy to have you send in a PR for this.