EventStore-DevOps icon indicating copy to clipboard operation
EventStore-DevOps copied to clipboard

Added nginx.conf to the package to avoid the need for a custom zip

Open coreyperkins opened this issue 9 years ago • 2 comments

coreyperkins avatar Aug 01 '16 18:08 coreyperkins

As you are adding DSx_v2 size VMs, please add the other sizes, from Standard_D1_v2 to at least Standard_D5_v2. Also, since many people will use the template to set up something for testing, please leave the default instance size at DS2 (DS2_v2 is fine since it is the same cost). I do not want to burn through my MSDN credits using a VM size bigger than necessary.

If you fix the size of VMs, I will merge the pull request.

Also, I would like to see things more configurable,

  • parameter to configure Run Projections or not, can default to true.
  • parameter to use nginx or not. See issue #5. It would also good to provide guidance in the read me on why people should be using nginx in this configuration.

pbolduc avatar Aug 02 '16 04:08 pbolduc

Sorry for the delay, I was on vacation (out of the country) for most of October. I was really busy before going on vacation and did not time to review your recent changes. I hope to get caught up this week and find time this weekend to get these changes merged.

pbolduc avatar Oct 25 '16 20:10 pbolduc