Pavel Bludov

Results 26 comments of Pavel Bludov

The PR is ready for review. I'm not going to assign anyone till GSOC ends.

I don't like these changes either. Let's drop this PR.

@rnveach should this issue be closed? Will there be more PR?

> [INFO] PMD Failure: com.puppycrawl.tools.checkstyle.Checker:64 Rule:TooManyMethods Priority:3 This class has too many methods, consider refactoring it. We use [MethodCount](https://checkstyle.org/config_sizes.html#MethodCount) check to control the number of methods. This rule should be...

> Just curious why we can't configure PMD to act the same as our check? Good point. I thought that `TooManyMethods` is a new rule. Done.

> I assume there must have been some bug in PMD that this wasn't an issue before. Looks like it is https://github.com/pmd/pmd/issues/3729

Such a property should not be added per check, but one at the TreeWalker level. I agree with @strkkk that this will be a difficult and confusing way. We need...

I am against complicating the check. Such property will fix this particular issue, but it won't work for another. Suppressions are more flexible.

@ZuevKirill95 please rebase the PR and fix [IntelliJ IDEA violations](https://teamcity.jetbrains.com/viewLog.html?buildId=3922435&tab=Inspection&buildTypeId=Checkstyle_IdeaInspectionsPullRequest)