rtl_433-hass-addons icon indicating copy to clipboard operation
rtl_433-hass-addons copied to clipboard

Feature Request: Compatibility with secrets.yaml

Open Ninja1283 opened this issue 2 years ago • 4 comments

Somewhat related to #8, are you able to add compatibility with the Home Assistant secrets file to avoid having plaintext credentials stored in the config?

Ninja1283 avatar Jul 28 '21 01:07 Ninja1283

To do that, I think we'd need to parse the secrets.yaml file (with python?), but then we'd end up having to write them back out to disk (following the work at https://github.com/pbkhrv/rtl_433-hass-addons/pull/14). Or, we'd have to use the -F option instead when starting the process (as it does look like rtl_433 excludes the username and password settings from the process listing).

deviantintegral avatar Jul 28 '21 21:07 deviantintegral

We no longer require secrets to be stored in the config, as long as you're using the MQTT broker within Home Assistant. Does that solve this need for you?

deviantintegral avatar Jan 12 '22 02:01 deviantintegral

We no longer require secrets to be stored in the config, as long as you're using the MQTT broker within Home Assistant. Does that solve this need for you?

The main addon documentation still says that "the absolute minimum that you need to specify in the config file is the MQTT connection and authentication information: output mqtt://HOST:PORT,user=XXXX,pass=YYYYYYY"

Is that not still the case?

Additionally, for people using auto discovery and an external MQTT server location, plaintext secrets are still stored in the config. I suppose using manually configured entities and/or using the Mosquito broker within HA would be able to eliminate this issue, but there are still some edge-case scenarios to think about.

Ninja1283 avatar Jan 15 '22 01:01 Ninja1283

No, it's not, and we should improve that text.

and an external MQTT server location

Yes, that's what I was trying to get at - there's no way for us to autodetect those credentials. secrets.yaml would be a nice improvement for those setups, and while I don't expect to prioritize it myself (since I wouldn't use it!) I'm glad to review and test PRs.

deviantintegral avatar Jan 17 '22 02:01 deviantintegral