koin.dart icon indicating copy to clipboard operation
koin.dart copied to clipboard

(koin) fix: fix get() called to nullable variable type exception

Open rIIh opened this issue 3 years ago • 1 comments

After this change it is safe to use get() on nullable type variables. Previously such interaction has throw NoBeanDefFoundException.

In Kotlin generic T type full name is not has '?' ending as it has in Dart language. Because of that IMO we should use only non nullable type names for index keys.

rIIh avatar Sep 02 '21 16:09 rIIh

Codecov Report

Merging #14 (11104d0) into master (91846f7) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   93.68%   93.69%   +0.01%     
==========================================
  Files          30       30              
  Lines         807      809       +2     
==========================================
+ Hits          756      758       +2     
  Misses         51       51              
Impacted Files Coverage Δ
...s/koin/lib/src/definition/provider_definition.dart 98.52% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91846f7...11104d0. Read the comment docs.

codecov-commenter avatar Sep 02 '21 16:09 codecov-commenter

Seems to be abandoned

Closing

rIIh avatar Nov 16 '22 09:11 rIIh