Paul Biron

Results 102 comments of Paul Biron

In the case of a non-existent `(post|comment)_parent`, the post/comment becomes top-level (i.e., `parent == 0`. Which makes sense for those cases, but doesn't really make sense for `[gallery]`. The closest...

> Options 1 and 2 lead to data loss. You can't really go back and fix things unless you store the old state somewhere. Option 1 definitely leads to data...

> so why even bother doing that in the first place? For the same reason that an imported post whose content is: ``` blah, blah, blah ``` becomes ``` blah,...

> But there you get at least one correct image. However, the gallery would still be broken, no? With option 2 you would get at least one correct image in...

> If galleries should be migrated, it should probably not run automatically. Instead, show a checkbox with a warning or something. If a gallery can't be fixed accurately, skip that...

In case anyone is wondering how a WXR file could contain a post that has a gallery with image IDs that aren't also included in the WXR, there are several...

I've got a fix for this but can't yet submit a PR for it until the [Simple namespace-aware parsing](https://github.com/humanmade/WordPress-Importer/pull/119) PR is merged because the fix for this relies on the...

@dcavins Glancing thru the changes in your PR it looks like your fix is more complete than mine (one of these days I'll wrap my head around the `$this->mapping` and...

@dcavins I just had a chance to review your PR and it passed all the tests I wrote for it. So, hopefully, it'll get merged soon.