QOwnNotes icon indicating copy to clipboard operation
QOwnNotes copied to clipboard

[BUG] minor optical issue with hyperlinks in disabled panels

Open j-schumann opened this issue 5 months ago • 5 comments

Those are two separate issues. Can you please open another one?

Originally posted by @pbek in #3307

Sure, here we go, very low prio:

QOwnNotes version 25.7.1 Built on Jul 2 2025 with Qt 6.6.1. dark mode enabled, use dark mode icons enabled

Image

When a panel containing marked up text w/ hyperlinks is disabled / greyed out, the hyperlinks aren't "dimmed", they are displayed like active panel hyperlinks. Seen in the script settings screen, script description panel, but proably happens in other places too. Don't know if this happens in light mode too.

j-schumann avatar Jul 03 '25 12:07 j-schumann

Hm, need to look if that's fixable easily... 🤔

pbek avatar Jul 03 '25 12:07 pbek

Turned out to be an issue of QLabel. I tried to implement a handling of the link color, then the labels are disabled.

25.7.2

  • The link color in disabled labels was changed to be more toned down (for #3314)

pbek avatar Jul 04 '25 19:07 pbek

There now is a new release, could you please test it and report if it works for you?

pbek avatar Jul 04 '25 20:07 pbek

version 25.7.2 - GitHub Actions - build 1199, Built on Jul 4 2025 with Qt 6.6.1. Sorry, does not work (for every panel):

Image

Browserextension > Socket Server disabled: the "here" link is bright as w/ socket server enabled.

Image

Nextcloud-Settings > Nextcloud support disabled

Could not test on the script settings panel as after the last fix the description of the last script now disappears after uninstall.

But please, don't invest too much time into this, there are probably more important issues :)

j-schumann avatar Jul 04 '25 23:07 j-schumann

I guess that's because those labels are not disabled by themselves, but the surrounding frame is disabled. 🤔

pbek avatar Jul 05 '25 07:07 pbek