Code block line with 17 spaces indent prevents further rendering of the preview

[Waqar144]

Expected behaviour

Code blocks line with 17 spaces indent should be rendered like normal

Actual behaviour

Code blocks line with 17 spaces indent don't get rendered at all Ex:

    ```
                 hello
    ```

will not get rendered and will prevent any further text from rendering as well.

[pbek]

I know just the man to fix that. :laughing: :arrow_up:

[davuses]

I ran into this bug today, if there is a Code blocks line with 17 spaces indent, all the content below won't be rendered in preview mode.

[Waqar144]

I will try to do a proper bump

[pbek]

22.11.0

• a preview issue with 17 spaces in code-blocks was fixed

[pbek]

I will try to do a proper bump

awesome!

[Waqar144]

can you hard reset the commit? It's causing conflicts

[pbek]

All our diverging commits are causing conflicts. The file structure of the md4c project changed.

This commit https://github.com/qownnotes/md4c/commit/f6b41fe14c05530447e5d93d5fbabd8f293c084c is just https://github.com/mity/md4c/commit/c595c2ed0076616856634332c35a7a3c851b287c#diff-c117525877f3cea55f4757cd7f32ea258050f83a845a9e9c33ef51e7214232dd and shouldn't cause any more troubles than our other commits...

I guess it would be best to just start with a clean https://github.com/mity/md4c/ on your side.

[Waqar144]

I have merged the master of original repo already,

[Waqar144]

If you reset the repo to the previous commit, i can push

[pbek]

I have merged the master of original repo already,

Are our modifications in already? I'll test your fork locally when you are done and will pull / reset it in after that. Hard-resetting now will break the current version of QOwnNotes.

[Waqar144]

Hard-resetting now will break the current version of QOwnNotes.

It won' I thinkt. Just hard reset the commit then merge the following branch to master and push and then bump that in QON. https://github.com/qownnotes/md4c/tree/work/update-md4c

With the bump cmake file and qmake file needs minor changes

[Waqar144]

https://github.com/pbek/QOwnNotes/pull/2641 created. It contains the cmake/qmake changes needed to build. But the build will fail currently as the module needs to be bumped

[pbek]

@sanderboom, @davuses There now is a new release, could you please test it and report if it works for you?

[pbek]

22.11.1

• the Markdown to HTML converter library md4c was updated to get the latest fixes and improvements (for #1732, thank you, @Waqar144)

There now is a new release, could you please test it and report if it works for you?

[sanderboom]

Works like a charm :rocket:

[pbek]

Awesome!