Paul T. Bauman
Paul T. Bauman
Thanks to @roystgnr and @dmcdougall for criticism. Points that were discussed: - Can get rid of global enum by using a factory type thing (e.g. how libMesh handles adding variables)...
In particular, the `GRINS::LowMachNavierStokesBase` and `GRINS::ReactingLowMachNavierStokesBase classes`. Problem is I used a different templating scheme for the former. Need to update the former to use the templating scheme of the...
I like having the builder modules in SimulationBuilder because it keeps the Simulation API simple and makes it easy to extend We should just provide (const) accessors to each of...
We assume the same number of reactants and products and use that assumption in several places. We need to remove it. The main thing is that means we have to...
Many places throughout the code, I check input values with some logic for the mandatory input options. However, I just learned about `GetPot::have_variable`. This would be a much better way...
As first mentioned #78: The VMS part of the Boussinesq term in the momentum equations does really weird things in the convective_cell example; changes the time scale of the solution,...
This would be an alternative to pinning the pressure with a penalty term. We would, of course, still keep the existing penalty version around. Would only apply for using PETSc...
Definitely in the "would be nice" category. Right now, I'm using libMesh::Real just about everywhere. I'm thinking we typedef a GRINS::Real which can default to libMesh::Real. Then, we can have...
I have not been able to get the mass injection example to work. I suspect it's the stabilization, but it very well could be related to #52. Might be a...
The cavity benchmark is currently using the following equation to solve for the thermodynamic pressure: {{latex(P_{th} = P_0\left(\int_{\Omega}\frac{1}{T_0}\;dx\right)\left(\int_{\Omega}\frac{1}{T}\right)^{-1})}} This is what Becker and Braack use. And it works fine for...