rocketchat-dark-mode icon indicating copy to clipboard operation
rocketchat-dark-mode copied to clipboard

Published 20 hours ago • verified publisher icon pbaity

Add translations for dark mode toggle button tooltip

Open pbaity opened this issue 4 years ago • 10 comments

The tooltip for the dark mode toggle button is only in English and Russian. In any other language setting it stays in English.

It'd be great for users who are native speakers of the other languages offered in RocketChat to add translations to the tooltip to dark-mode-toggle.js. We need translations for:

  • [x] German (#45)
  • [x] French (#102)
  • [x] Spanish (#83)
  • [x] Italian (#126)
  • [ ] Dutch
  • [ ] Polish
  • [x] Portuguese (#51)
  • [x] Chinese (#160)
  • [x] Hebrew (#55)
  • [x] Hindi (#68)
  • [x] Hungarian (#70)

NOTE: This list is not exhaustive. If your language is not in this list, please add it anyway!

P.S. Google Translate is not what we're looking for. "Toggle Dark Mode" isn't communicated the same in other languages. It'd be best for it the tooltip text to read naturally to native speakers, rather than a possibly robotic-sounding translation by Google.

pbaity avatar Apr 29 '20 17:04 pbaity

Can I take part in Chinese translation? Although mine is not very good, because I know rocket very well, I know what Chinese users need

y377 avatar May 11 '20 11:05 y377

@rapliu Please do! The languages I listed above are the ones I found codes for in Rocket.Chat, but I'm sure that's not an exhaustive list. In dark-mode-toggle.js, in the const darkModeToggleText object, just add a line for Chinese and open a pull request.

Don't worry if it's not a perfect translation - if another Chinese-speaking user notices a problem with it, we can fix it then.

pbaity avatar May 11 '20 12:05 pbaity

@y377 Still interested in offering a Chinese translation?

pbaity avatar Jul 23 '20 00:07 pbaity

In German Dark Mode umschalten should be fine. We have not really a German term for dark mode.

fdellwing avatar Aug 05 '20 06:08 fdellwing

Thanks @fdellwing , added in #45

pbaity avatar Aug 05 '20 16:08 pbaity

Although Hindi is not mentioned above, shall I add a Hindi translation for the tooltip?

aradhya-gupta avatar Sep 29 '20 05:09 aradhya-gupta

@aradhya-gupta Please do! I took the list above from this file in the RocketChat repository, but I think these are just the languages that support auto-translation. I'm adding Hindi to the list now.

pbaity avatar Sep 29 '20 12:09 pbaity

French traduction is : "Activer le mode sombre".

bseclier avatar Dec 09 '20 10:12 bseclier

Thanks @bseclier , after a long holiday break I added your translation in #102.

pbaity avatar Jan 12 '21 15:01 pbaity

Yeah, I've been waiting for you to assign me something to translate

y377 avatar Apr 19 '22 08:04 y377