openapi-changes icon indicating copy to clipboard operation
openapi-changes copied to clipboard

Bug : Summary diff number differs from HTML report in some cases (not really determined)

Open LasneF opened this issue 1 year ago • 1 comments

given the same command line

HTML report gives this image

vs summary report gives this

❌ 1 Breaking changes out of 46 INFO Modifications: 5 INFO Removals: 24 INFO Additions: 14

looks the 46 a bit weird as summing the info it gives 43 , as same as on the HTML report

LasneF avatar Nov 26 '24 16:11 LasneF

further investigation show case that it may be linked toward handling adding a path in the new file

here is the summary

Date: 11/26/24 | Commit: New: .\perforce copy.yaml, Original: component-descriptor.yml Document Element | Total Changes | Breaking Changes paths | 34 | 1 components | 14 | 0

❌ 1 Breaking changes out of 48 INFO Modifications: 9 INFO Removals: 24 INFO Additions: 12

but here is the report json

{ "reportSummary": { "components": { "totalChanges": 14, "breakingChanges": 0 }, "paths": { "totalChanges": 34, "breakingChanges": 1 } },

and the HTML report image

something may be to handle at same time as this https://github.com/pb33f/openapi-changes/issues/148

LasneF avatar Nov 26 '24 17:11 LasneF