payu icon indicating copy to clipboard operation
payu copied to clipboard

Add staged CABLE driver for advanced configurations

Open Whyborn opened this issue 1 year ago • 2 comments

This driver is intended to facilitate spin-up CABLE configurations, which involve usually many stages with differing science configurations. An example experiment exists here, with some documentation: Staged_CABLE

Whyborn avatar Jul 11 '24 02:07 Whyborn

Hello @Whyborn! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-09-24 12:38:22 UTC

pep8speaks avatar Jul 11 '24 02:07 pep8speaks

I'll add some tests before requesting another review.

Whyborn avatar Aug 06 '24 12:08 Whyborn

Are you ready for another review @Whyborn?

aidanheerdegen avatar Sep 09 '24 06:09 aidanheerdegen

I had requested another one, but I have been doing some thinking since the Payu workshop session to improve the handling of restarts. I'll cancel the current request and add a new one after I make (or not make) some changes.

Whyborn avatar Sep 09 '24 06:09 Whyborn

I've made some adjustments to the way we retrieve the restarts, see the unresolved conversation. I've added tests to capture most of the desired functionality, but I was struggling to build a good test for retrieving restarts.

Whyborn avatar Sep 23 '24 05:09 Whyborn

I think I'm at the end of my utility as a reviewer. I see @ccarouge has a few more suggestions, but after that probably best to merge it and start using it and iterate if there are problems, or improvements required. You're not touching any other drivers, so it's fairly side-effect free and you can test it, as can others.

aidanheerdegen avatar Sep 24 '24 07:09 aidanheerdegen