react-paypal-js icon indicating copy to clipboard operation
react-paypal-js copied to clipboard

[BUG]: Text is not visible on dark background

Open YousifRagab opened this issue 2 years ago • 2 comments

Is there an existing issue for this?

  • [x] I have searched the existing issues.

🐞 Describe the Bug

All texts, titles, and the close button are designed for a light background, using a dark background results in these texts being barely visible.

Does the package support dark mode? Or is there any way to use white color for texts instead of black?

😕 Current Behavior

All texts, titles, and the close button are not visible like in the screenshot below PayPal_0

Here's the highlighted texts as well PayPal_1

🤔 Expected Behavior

These texts and close button should be white when using a dark background

🔬 Minimal Reproduction

1- Create a new app
2- use a dark background
3- Integrate PayPal Buttons

🌍 Environment

| Software         | Version(s)      |
| ---------------- | --------------- |
| react-paypal-js  | 7.8.1           |
| Browser          | FireFox 101.0.1 |
| Operating System | Windows 10      |

Relevant log output

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

➕ Anything else?

I only found one issue about this and it was closed recently with no solution.

YousifRagab avatar Jun 18 '22 11:06 YousifRagab

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

github-actions[bot] avatar Aug 03 '22 02:08 github-actions[bot]

For anyone wondering, I ended up creating a transparent background for the buttons, and when the purchase button is clicked, the background's color is set to white, and when the screen is closed the background will return to be transparent again.

Not the best solution, but it works.

YousifRagab avatar Aug 04 '22 18:08 YousifRagab

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

github-actions[bot] avatar Sep 19 '22 02:09 github-actions[bot]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

github-actions[bot] avatar Sep 25 '22 02:09 github-actions[bot]

Why this issue is closed? I have the similar problem with black background. Please give the option to change debit card label font color.

naingaungphyo avatar Nov 20 '22 10:11 naingaungphyo