paypal-messaging-components
paypal-messaging-components copied to clipboard
ci: failed snapshot comparison halts release
Description
- Removed
continue-on-errorto prevent failed snapshot comparisons from allowingReleaseworkflow
This PR should be considered after snapshots have been updated.
Screenshots
Testing instructions
Snapshots Failing Are Unrelated To This PR Change
I believe many of the snapshots (like so)
● IT > text (Test Count: 66) › > DEV0000ITPLNQ (Test Count: 22) › Small viewport › IT/DEV0000ITPLNQ/text/logo.type-primary_text.position-left
Expected image to match or be a close match to snapshot but was 3.9174484052532836% different from snapshot (522 differing pixels). See diff for details: tests/functional/snapshots/IT/DEV0000ITPLNQ/text/diff_output/logo.type-primary_text.position-left-200-diff.png
are failing because of this
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
rather than it being related to the changes made in the workflow by this PR.
The issue mentions
Rollout will begin on December 5th and will complete on January 17th, 2025.
So, there's the potential that these snapshots were generated on separate systems.
Checking against this CI run, I see that our actions were using ubuntu 22.04.5 for ubuntu@latest, but are now using ubuntu 24.04.1
Preivous Run
Current Run
:tada: This PR is included in version 1.68.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: