paypal-checkout-components icon indicating copy to clipboard operation
paypal-checkout-components copied to clipboard

Update APM buttons with new default colors

Open ericyupaypal opened this issue 2 years ago • 6 comments

Description

  • Update default button colors for APMs to match individual payment scheme branding

Why are we making these changes? Include references to any related Jira tasks or GitHub Issues

  • https://engineering.paypalcorp.com/jira/browse/DTALTPAY-993

Screenshots (if applicable)

screencapture-localhost-paypal-9001-webpack-dev-server-demo-dev-index-htm-2022-09-12-17_10_25

Dependent Changes (if applicable)

  • Dependency on paypal-sdk-logos PR, https://github.com/paypal/paypal-sdk-logos/pull/68, to use new APM logos created for these new background colors. If used with old version of paypal-sdk-logos, logos may be illegible on new colored button backgrounds.

Groups who should review (if applicable)

  • AltPay Experience
  • Checkout SDK

❤️ Thank you!

ericyupaypal avatar Aug 16 '22 23:08 ericyupaypal

Image 2022-08-22 at 16 43 41

Does the Boleto test look okay?

wsbrunson avatar Aug 22 '22 21:08 wsbrunson

Is that typical for the screenshots from the test to have that shaded box? I see it on most of the test screenshots https://github.com/paypal/paypal-checkout-components/pull/1989/files

jscheinhorn avatar Aug 22 '22 22:08 jscheinhorn

Is that typical for the screenshots from the test to have that shaded box? I see it on most of the test screenshots https://github.com/paypal/paypal-checkout-components/pull/1989/files

It might be graying out the label for the sake of flakeyness but we will verify that.

wsbrunson avatar Aug 22 '22 22:08 wsbrunson

I'll double check this. I would expect the logo to show up and the label greyed out. It's only showing the greyed out label, so will look into why the logo is not rendering. I am wondering if it's due to how we have both FUNDING.BOLETO and FUNDING.BOLETOBANCARIO in the test config.

ericyupaypal avatar Aug 22 '22 22:08 ericyupaypal

I didn't realize both FUNDING.BOLETO and FUNDING.BOLETOBANCARIO were used. Before, I just enabled the new styling on FUNDING.BOLETO, which led to the bad screenshot test for FUNDING.BOLETOBANCARIO. Updated and committed changes to support FUNDING.BOLETOBANCARIO also now.

ericyupaypal avatar Aug 22 '22 23:08 ericyupaypal

I didn't realize both FUNDING.BOLETO and FUNDING.BOLETOBANCARIO were used

I think BOLETOBANCARIO replaced BOLETO but the work to remove BOLETO from the codebase still needs to be completed

wsbrunson avatar Aug 22 '22 23:08 wsbrunson

The package version of @paypal/sdk-logos will need to be updated with the new major version once it's updated and published, https://github.com/paypal/paypal-checkout-components/blob/main/package.json#L98

ericyupaypal avatar Sep 22 '22 17:09 ericyupaypal

Codecov Report

Base: 58.40% // Head: 56.97% // Decreases project coverage by -1.43% :warning:

Coverage data is based on head (3603704) compared to base (a829473). Patch coverage: 39.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1989      +/-   ##
==========================================
- Coverage   58.40%   56.97%   -1.44%     
==========================================
  Files         103      103              
  Lines        1743     1822      +79     
  Branches      449      466      +17     
==========================================
+ Hits         1018     1038      +20     
- Misses        682      727      +45     
- Partials       43       57      +14     
Flag Coverage Δ
jest 36.75% <4.39%> (-1.98%) :arrow_down:
karma 52.66% <45.23%> (-0.94%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/funding/card/config.jsx 77.58% <ø> (ø)
src/funding/ideal/config.jsx 50.00% <ø> (ø)
src/ui/buttons/props.js 80.00% <ø> (ø)
src/ui/buttons/styles/color.js 100.00% <ø> (ø)
src/zoid/card-form/component.js 25.00% <ø> (ø)
src/zoid/checkout/component.jsx 88.46% <ø> (ø)
src/zoid/payment-fields/component.jsx 100.00% <ø> (ø)
src/funding/bancontact/config.jsx 50.00% <33.33%> (-50.00%) :arrow_down:
src/funding/blik/config.jsx 50.00% <33.33%> (-50.00%) :arrow_down:
src/funding/boleto/config.jsx 50.00% <33.33%> (-50.00%) :arrow_down:
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 03 '22 18:10 codecov[bot]