paypal-android icon indicating copy to clipboard operation
paypal-android copied to clipboard

Make CCO Call for all PayPal Web Checkout Funding Sources

Open sshropshire opened this issue 7 months ago • 7 comments

Summary of changes

  • This PR moves UpdateClientConfigAPI to CorePayments so that it is accessible from all modules.
  • This PR also updates CCO for all PayPalWebCheckout funding sources

Checklist

  • [ ] ~Added a changelog entry~

Authors

List GitHub usernames for everyone who contributed to this pull request.

  • @sshropshire

sshropshire avatar Jul 08 '25 16:07 sshropshire

Steven, I'm a bit confused, are you going to replace https://github.com/paypal/paypal-android/pull/314 with this PR and another one for the card button?

KunJeongPark avatar Jul 09 '25 04:07 KunJeongPark

Steven, I'm a bit confused, are you going to replace #314 with this PR and another one for the card button?

This PR is going to merge into that one. We will still need a complete overview of the BCDC feature.

sshropshire avatar Jul 09 '25 14:07 sshropshire

Are you including the paypal-context-id in the header? In iOS, we are passing it in in the networkClient.fetch in UpdateClientConfigAPI.

KunJeongPark avatar Jul 09 '25 16:07 KunJeongPark

Are you including the paypal-context-id in the header?

Yes we're also setting it here in UpdateClientConfigAPI.kt

sshropshire avatar Jul 09 '25 16:07 sshropshire

@KunJeongPark that's a good catch though, the header name is incorrect. I'll update.

sshropshire avatar Jul 09 '25 16:07 sshropshire

@KunJeongPark actually should it be paypal-context-id? I noticed the header is also named paypal-client-context on iOS.

sshropshire avatar Jul 09 '25 16:07 sshropshire

@KunJeongPark actually should it be paypal-context-id? I noticed the header is also named paypal-client-context on iOS.

you are right, I misspoke

KunJeongPark avatar Jul 09 '25 16:07 KunJeongPark