payload icon indicating copy to clipboard operation
payload copied to clipboard

(CTRL | CMD) + S still works with with autosave set

Open PP-Tom opened this issue 1 year ago • 1 comments

Describe the Bug

When you have autosave set, it's still possible to create a draft with CTRL + S or CMD + S, this creates unexpected behaviour such as deleting search indexes.

Link to the code that reproduces this issue

pnpx create-payload-app@latest -t blank

Reproduction Steps

  1. Enable autosave on a collection.
  2. Press CTRL + S or CMS + S

Which area(s) are affected? (Select all that apply)

plugin: search, Not sure

Environment Info

Payload: 3.4.0
NodeJS: 22
NextJS: 15.0.3

PP-Tom avatar Dec 05 '24 14:12 PP-Tom

Please add a reproduction in order for us to be able to investigate.

Depending on the quality of reproduction steps, this issue may be closed if no reproduction is provided.

Why was this issue marked with the invalid-reproduction label?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We prefer a link to a public GitHub repository created with create-payload-app@beta -t blank or a forked/branched version of this repository with tests added (more info in the reproduction-guide).

To make sure the issue is resolved as quickly as possible, please make sure that the reproduction is as minimal as possible. This means that you should remove unnecessary code, files, and dependencies that do not contribute to the issue. Ensure your reproduction does not depend on secrets, 3rd party registries, private dependencies, or any other data that cannot be made public. Avoid a reproduction including a whole monorepo (unless relevant to the issue). The easier it is to reproduce the issue, the quicker we can help.

Please test your reproduction against the latest version of Payload to make sure your issue has not already been fixed.

I added a link, why was it still marked?

Ensure the link is pointing to a codebase that is accessible (e.g. not a private repository). "example.com", "n/a", "will add later", etc. are not acceptable links -- we need to see a public codebase. See the above section for accepted links.

Useful Resources

github-actions[bot] avatar Dec 05 '24 14:12 github-actions[bot]

I don't think this issue is in particular with the hotkey to save while autosave is enabled. The search plugin issue can happen without autosave as well so I'll be fixing that by adding an additional check for a published version and only then removing the search doc if no published versions exist.

If you see any other issues regarding these flows let us know and we can handle that directly.

paulpopus avatar Feb 05 '25 14:02 paulpopus

🚀 This is included in version v3.21.0

github-actions[bot] avatar Feb 05 '25 19:02 github-actions[bot]

This issue has been automatically locked. Please open a new issue if this issue persists with any additional detail.

github-actions[bot] avatar Feb 13 '25 04:02 github-actions[bot]