payload icon indicating copy to clipboard operation
payload copied to clipboard

chore: translate checkbox result in collection list view

Open JessChowdhury opened this issue 9 months ago • 1 comments

Description

Closes #169 from payload-3.0-demo.

Adds true and false translations for the checkbox field result in the collection view.

  • [X] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • [X] Chore (non-breaking change which does not add functionality)

Checklist:

  • [X] Existing test suite passes locally with my changes

JessChowdhury avatar May 01 '24 12:05 JessChowdhury

@JessChowdhury what does it display if the bool is undefined? i.e. a field without a default value?

JarrodMFlesch avatar May 02 '24 20:05 JarrodMFlesch

@JessChowdhury what does it display if the bool is undefined? i.e. a field without a default value?

Screenshot 2024-05-03 at 2 44 12 PM

It should show <No {label}> as it did does in 2.0.

However, it got broken in 3.0 here - we previously had if(!CellComponent) and have since added if(!CellComponent && defaultComponent). I just pushed another change to fix this.

JessChowdhury avatar May 03 '24 13:05 JessChowdhury

@JarrodMFlesch the last commit here will also fix this issue on the 3.0 demo repo.

JessChowdhury avatar May 03 '24 14:05 JessChowdhury

Looks good, thanks!

JarrodMFlesch avatar May 03 '24 14:05 JarrodMFlesch