rust-payjoin icon indicating copy to clipboard operation
rust-payjoin copied to clipboard

Ffi javascript

Open spacebear21 opened this issue 1 month ago • 1 comments

Draft PR for JS bindings.

TODOs:

  • [x] Add javascript build-and-test CI workflow
  • [ ] Write an integration test. This will be tricky because _test-utils does not build on WASM targets due to the tokio net dependency.
  • [ ] io feature is disabled, so ideally the JS bindings should offer an alternative for fetching OHTTP keys.
  • [ ] Upstream uniffi-bindgen-react-native changes from my fork (or find alternative fix)
Pull Request Checklist

Please confirm the following before requesting review:

spacebear21 avatar Nov 13 '25 20:11 spacebear21

Pull Request Test Coverage Report for Build 19553229768

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.578%

Totals Coverage Status
Change from base Build 18946545260: 0.0%
Covered Lines: 8988
Relevant Lines: 10754

💛 - Coveralls

coveralls avatar Nov 13 '25 20:11 coveralls

This is some awesome work, gonna see if there's anything I can catch, probably minor things

chavic avatar Nov 20 '25 09:11 chavic

Thanks for the reviews @DanGould and @chavic, I think I addressed all of your comments in the latest push and replies.

spacebear21 avatar Nov 20 '25 22:11 spacebear21