rust-payjoin icon indicating copy to clipboard operation
rust-payjoin copied to clipboard

Flake check fixes

Open nothingmuch opened this issue 4 months ago • 1 comments

With #915 we no longer require docker to run integration tests. This lets us run the integration tests in the nix sandbox.

This PR makes nix flake check work again, and enables the integration tests.

Currently marked draft due to dependency on that PR, and because this should also add a github workflow job to actually run nix flake check (with caching, see #457)

Depends on #915

TODO:

  • [ ] msrv
  • [ ] nix run .#shfmt
  • [ ] taplo #1027
  • [ ] missing checks from github workflows

Pull Request Checklist

Please confirm the following before requesting review:

nothingmuch avatar Aug 29 '25 20:08 nothingmuch

Pull Request Test Coverage Report for Build 17333460960

Details

  • 536 of 642 (83.49%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 86.041%

Changes Missing Coverage Covered Lines Changed/Added Lines %
payjoin-test-utils/src/lib.rs 6 7 85.71%
payjoin-directory/src/config.rs 0 3 0.0%
payjoin-directory/src/main.rs 0 3 0.0%
payjoin-directory/src/db/mod.rs 0 14 0.0%
payjoin-directory/src/lib.rs 12 31 38.71%
payjoin-directory/src/db/files.rs 518 584 88.7%
<!-- Total: 536 642
Files with Coverage Reduction New Missed Lines %
payjoin-directory/src/config.rs 1 0.0%
payjoin-directory/src/lib.rs 1 61.32%
payjoin-directory/src/main.rs 1 0.0%
<!-- Total: 3
Totals Coverage Status
Change from base Build 17332008623: 0.1%
Covered Lines: 8617
Relevant Lines: 10015

💛 - Coveralls

coveralls avatar Aug 29 '25 20:08 coveralls

with the redis stuff merged in what commits remain from this PR?

benalleng avatar Nov 25 '25 21:11 benalleng

Closed as rebased into #1210

benalleng avatar Dec 10 '25 13:12 benalleng