rust-payjoin icon indicating copy to clipboard operation
rust-payjoin copied to clipboard

`cargo test -p payjoin` fails

Open nothingmuch opened this issue 4 months ago • 6 comments

8ceccaab611e4a075dada66718b1ecd1d2e4a4ee broke test builds with the default features:

error[E0432]: unresolved import `crate::send::v1`
   --> payjoin/src/core/send/v2/session.rs:108:22
    |
108 |     use crate::send::v1::SenderBuilder;
    |                      ^^ could not find `v1` in `send`
    |

nothingmuch avatar Aug 29 '25 14:08 nothingmuch

cc @DanGould

nothingmuch avatar Aug 29 '25 14:08 nothingmuch

The session tests must not use v1::SenderBuilder. Use v2 with NoOp persister.

DanGould avatar Aug 29 '25 15:08 DanGould

I wonder why this isn't tested by CI

DanGould avatar Aug 29 '25 15:08 DanGould

because payjoin/contrib/test.sh only tests with --all-features

nothingmuch avatar Aug 29 '25 16:08 nothingmuch

Going to take this and look into adding a test suite that doesn't use --all-features

benalleng avatar Sep 02 '25 16:09 benalleng

The exact error linked https://github.com/payjoin/rust-payjoin/issues/1019#issue-3367138588 has actually been resolved as of d6ab28d1ddf3737e0e68abe1ce5ff0b14ccd3a8d however several other errors still exist when running cargo test -p payjoin

benalleng avatar Oct 29 '25 16:10 benalleng