Payara icon indicating copy to clipboard operation
Payara copied to clipboard
verified publisher icon payara

FISH-12264: remove test-domain-setup module from Payara Samples (payara7)

Open astoica1 opened this issue 1 month ago • 2 comments

Description

  1. This PR eliminates the test-domain-setup module from the samples and moves the remaining functionality directly into the respective test classes.
  2. Moves ejb-invoker-secure-endpoint under samples

Testing

Local run: mvn -V -B -ff clean install --strict-checksums -Ppayara-server-remote,playwright -Djavax.net.ssl.trustStore=/Library/Java/JavaVirtualMachines/zulu-21.jdk/Contents/Home/lib/security/cacerts -Djavax.xml.accessExternalSchema=all -Dpayara.home=/Payara7/appserver/distributions/payara/target/stage/payara7/ -f appserver/tests/payara-samples

Jenkins run: https://jenkins.payara.fish/job/CI-PR-Testing/job/Payara%20Community%20PR%20Testing/job/PR-7790/3/

astoica1 avatar Nov 27 '25 07:11 astoica1

Changing base: the Payara7 branch has been merged into main and is now defunct - it will be deleted Soon™

Pandrex247 avatar Dec 04 '25 17:12 Pandrex247

Changing base again to a feature branch: FISH-12635-Rework-Payara-Samples This is to allow us to iterate on this across multiple PRs and not commit anything to main until the rework is Done™

Pandrex247 avatar Dec 10 '25 11:12 Pandrex247

So, I still have a few question.

  • If a test fails, how easily / quickly would be to reproduce a failure by just running a single test?
  • Have you compared the total runtimes before / after? Does this blow up the execution times by orders of magnitude?
  • Does this require restarting payara before each test? If yes, this is an issue because it removes one aspect of these tests, the testing of deploy/undeploy for the samples.

The issue is that this undoes about 2 months of my hard work making the samples actually worthwhile and productive to look / debug Payara if some of the tests fail.

lprimak avatar Dec 22 '25 02:12 lprimak