Payara icon indicating copy to clipboard operation
Payara copied to clipboard

Enhancement: Add migration proposal for deprecated plugin parameters/FISH-12160

Open pzygielo opened this issue 5 months ago • 3 comments

Brief Summary

  • Currently, with https://github.com/payara/ecosystem-maven/pull/444 the new plugin reports:
[INFO] --- payara-micro:2.5:start (...) @ war ---
[WARNING]  Parameter 'payaraVersion' (user property 'payaraVersion') is deprecated: No reason given

The https://docs.payara.fish/community/docs/Technical%20Documentation/Ecosystem/Project%20Management%20Tools/Maven%20Plugin.html

Image

still uses payaraVersion

Image

(NB as {page-version})

Expected Outcome

Something like

[WARNING]  Parameter 'payaraVersion' (user property 'payaraVersion') is deprecated: use XYZ instead

Current Outcome

[WARNING]  Parameter 'payaraVersion' (user property 'payaraVersion') is deprecated: No reason given

Alternatives

Read the plugin sources to find out replacement properties.

Context

No response

pzygielo avatar Jul 31 '25 09:07 pzygielo

I see some attempt to consider this in plugin 2.5.1, but it does not work:

[INFO] --- payara-micro:2.5.1:start (XXX) @ YYY ---
[WARNING]  Parameter 'payaraVersion' (user property 'payaraVersion') is deprecated: No reason given
[INFO] No Jakarta EE dependency found. Using latest Payara Micro version: 7.2025.1.Alpha3
[INFO] Resolving fish.payara.extras:payara-micro:jar:7.2025.1.Alpha3
[INFO] Starting payara-micro from path: ...

so I can't see https://github.com/payara/ecosystem-maven/commit/f59fba8805dec7c99bdfb429c7828d9943991a6f#diff-24ac136c1716af62f28932bd8d553116cf5fac348ef6cd07468efe7e37043116R202

Also - I'd think that javadocing @deprecated would cause the original direct warning from maven ([WARNING] Parameter 'payaraVersion' (user property 'payaraVersion') is deprecated: No reason given) to include the reason already... IMO - much better than the series of (now not seen in action) getLog().warns...

pzygielo avatar Aug 04 '25 08:08 pzygielo

Created internal ticket FISH-12160 to address the issue.

jGauravGupta avatar Sep 29 '25 13:09 jGauravGupta

Hello @pzygielo, as Gaurav mentioned above, this has been escalated directly to him to address, and the enhancement request will be mentioned in the release notes as FISH-12160. Thank you very much for your contribution to make our tools more clear and accessible.

felixif avatar Sep 30 '25 12:09 felixif