Payara icon indicating copy to clipboard operation
Payara copied to clipboard

Enhancement: Provide some details/reasons behind FISH-6037

Open pzygielo opened this issue 7 months ago • 4 comments

Brief Summary

  • https://github.com/payara/Payara/pull/5650#discussion_r2095961538

Expected Outcome

  • I'd like to learn about the source of EJB 4.1 DD XSD.

Current Outcome

  • I don't understand the change: https://github.com/payara/Payara/pull/5650#discussion_r2095961538

Alternatives

  • I considered to not care about that case. But I rejected that alternative so far.

Context

There is no EJB 4.1 spec (yet) and no JakartaEE 4.1 XSD for ejb-jar is known to me.

pzygielo avatar May 20 '25 10:05 pzygielo

If it turns out to be the case: https://github.com/payara/Payara/pull/5650#discussion_r2097663887

I suspect these are Payara-specific enhancements

I'd be satisfied.


Just what about the future EJB that might deliver new schema? 🤔

pzygielo avatar May 20 '25 11:05 pzygielo

I'd be satisfied.

Although I think the glassfish|sun-ejb-jar_*.dtd and the like would be better place for such enhancements instead of ejb-jar itself.

pzygielo avatar May 20 '25 13:05 pzygielo

Hello @pzygielo,

Thank you for reporting this weird version change. As my colleague said in the mentioned PR, the version must have been updated due to the fact that we integrated some Payara-specific features, but you raised a valid point about future version changes that may happen with future Jakarta EE versions, which would end up causing an issue with our current implementation.

I am not in a position to make these changes or decide in which deployment descriptor the version change should happen, so the best way to continue this discussion with my colleague on that PR that you linked.

If the version used in the deployment descriptor has caused any issues with any of your deployed applications, I would be more than happy to test a reproducer and escalate the issue. If not, would it be OK to close this issue and continue the discussion on that PR?

Best regards, Felix

felixif avatar May 20 '25 16:05 felixif

If the version used in the deployment descriptor has caused any issues

Not for me. I was just surprised to see the new schema, knowing nothing like that had been published by the spec.

would it be OK to close this issue and continue the discussion on that PR

But this would leave The Project with everything in that matter closed or completed. IMO the discussion, if any, should be continued here. If there is no need for changes, feel free to close. It's not for me to decide.

  • But even https://github.com/payara/Payara/issues/3042#issuecomment-948412002, having

An internal issue is created

is kept open since 2021.

Thanks for checking.

pzygielo avatar May 20 '25 17:05 pzygielo

Please re-close as not planned. I guess nothing has been done to eliminate non-existing schema and no other issue to do so in the future was referenced here.

pzygielo avatar Jul 01 '25 13:07 pzygielo