Bug Report: Cannot start docker container server-node with given INSTANCE_NAME and DEPLOYMENT_GROUP/FISH-6950

[jensgoe]

Brief Summary

If i start a server-node with given INSTANCE_NAME and DEPLOYMENT_GROUP the container does not start.

in Payara/appserver/extras/docker-images/server-node/src/main/docker/bin/entrypoint.sh startup script. an instance is created with:

ASADMIN_COMMAND="${ASADMIN} -I false -T -a -H ${PAYARA_DAS_HOST} -p ${PAYARA_DAS_PORT} -W ${PAYARA_PASSWORD_FILE} create-local-instance --node ${PAYARA_NODE_NAME} --dockernode true --ip ${DOCKER_CONTAINER_IP} ${PAYARA_INSTANCE_NAME} --deploymentgroup ${PAYARA_DEPLOYMENT_GROUP}"

my guess, the order of the arguments is not right. the instance name might be the last arguement? If i omit the DEPLOYMENT_GROUP argument the container starts up with the give instance name correctly.

A possible fix might be to move the instance_name argument to the end?

ASADMIN_COMMAND="${ASADMIN} -I false -T -a -H ${PAYARA_DAS_HOST} -p ${PAYARA_DAS_PORT} -W ${PAYARA_PASSWORD_FILE} create-local-instance --node ${PAYARA_NODE_NAME} --dockernode true --ip ${DOCKER_CONTAINER_IP} --deploymentgroup ${PAYARA_DEPLOYMENT_GROUP} ${PAYARA_INSTANCE_NAME}"

Expected Outcome

docker container starts with no errors

Current Outcome

docker logs shows:

/opt/payara/appserver/bin/asadmin -I false -T -a -H 10.135.0.203 -p 4848 -W /opt/ws/passwordfile create-local-instance --node Strange-Elver --config dg_config --dockernode true --ip 10.135.3.38 inst1 --deploymentgroup dg_app Command create-local-instance only accepts one operand Usage: asadmin [asadmin-utility-options] create-local-instance [--config | --cluster ] [--lbenabled[=]] [--systemproperties ] [--portbase ] [--checkports[=<checkports(default:true)>]] [--savemasterpassword[=<savemasterpassword(default:false)>]] [--nodedir ] [--node ] [-?|--help[=<help(default:false)>]] instance_name

Reproducer

start the server-node with the following command: docker container run -d --name my-node --network host --volume /opt/payara/ws/:/opt/ws/ -e PAYARA_PASSWORD_FILE=/opt/ws/passwordfile -e PAYARA_DEPLOYMENT_GROUP=dg_app -e PAYARA_CONFIG_NAME=dg_config -e PAYARA_DAS_HOST=10.135.0.203 -e PAYARA_INSTANCE_NAME=inst1 payara/server-node:5.2021.10

Operating System

Ubuntu 22.04

JDK Version

unnecessary

Payara Distribution

Payara Docker Image

[shub8968]

Hi @jensgoe,

I have escalated this issue to the platform development team as FISH-6950. Thanks