Paweł Miech
Paweł Miech
Tests unrelated to project name problem merged to master here: https://github.com/scrapy/scrapyd/commit/2eb5409ff2ed07e55543ed8babd58237780d29b7 this Pull Request will only contain sanitization of project name, to be merged later.
This is really nice work, but now has conflicts with master and also need to add some tests. It will require work integrating with master. I'll put it on roadmap...
Tests are failing because they need to be updated, change this ```python content = scrapyd_site.children[b'jobs'].render(txrequest) ``` to ```python content = scrapyd_site.children[b'jobs'].render_GET(txrequest) ``` and need to bring back content-type and content-length,...
I would use a separate template for `""` section of HTML document, and we can add some common css stylesheet there for both jobs and home. I played around in...
@mojtabaasadi I think we can just create default basic bit better UI with some open source CSS, like Twitter Bootstrap or Foundation, but your PR doesn't have to do this....
This introduces postgres and rabbitmq as dependencies, will increase technical debt. Also some things added here were already done in simpler way using sqlite here: https://github.com/scrapy/scrapyd/pull/359 and merged. So in...
integrated with current master here https://github.com/scrapy/scrapyd/compare/uds?expand=1
I get all HTTP 200 responses for quotestoscrape. Are you using quotesbot project? But when I test for redirects I see it actually doesn't filter out properly. Because it checks...
> With your adapter, can you try changing the s.get line from r = s.get("https://localhost:8080") to r = s.get("https://localhost:8080/")? same behavior. I actually see that example from docs also fails...