flame
flame copied to clipboard
feat: rework kubernetes annotations
New annotation:
# Enables flame to watch ingress
flame.pawelmalak/enabled
Changed annotations:
# defaults to ingress .metadata.name
flame.pawelmalak/name
# defaults to first ingress host found or if first ingress tls host found it uses that instead
flame.pawelmalak/url
This is helpful in reducing the amount of annotations needed for a basic setup.
Before:
annotations:
- flame.pawelmalak/type=application # required
- flame.pawelmalak/name=My container # required
- flame.pawelmalak/url=https://example.com # required
- flame.pawelmalak/icon=kubernetes # optional
After:
annotations:
- flame.pawelmalak/enabled=true # required
- flame.pawelmalak/type=application # optional
- flame.pawelmalak/name=My container # optional
- flame.pawelmalak/url=https://example.com # optional
- flame.pawelmalak/icon=kubernetes # optional
Closes: https://github.com/pawelmalak/flame/issues/290
@pawelmalak I'm curious how the flame.pawelmalak/type annotation should work since I didn't see you append that to the kubernetesApps array. I think we can default that to application if it needs to be in that array. Thanks for the app!
I endorse this PR for whatever that may be worth
@pawelmalak any thoughts?
@pawelmalak hello?