siema icon indicating copy to clipboard operation
siema copied to clipboard

New option - autoHeight?

Open jablonczay opened this issue 6 years ago • 9 comments

Hello,

First of all thank you for your fantastic work!

I think it would be very useful to add a new "autoHeight" option for the carousel. What is your opinion?

jablonczay avatar Oct 03 '17 09:10 jablonczay

Hi.

I was thinking about this a lot. It may happen at some point but probably not in 1.5. implementing this option requires quite big changes in current API as it needs to track and update height of each elements in carousel.

Thanks a lot again for you great suggestion!

pawelgrzybek avatar Oct 03 '17 10:10 pawelgrzybek

Thanks for the quick response!

Is there any simple way to implement this feature without changing the source code of Siema?

jablonczay avatar Oct 03 '17 10:10 jablonczay

@pawelgrzybek Hi, can u help me pls? I need to style the pagination of an active slide, how can i do it? maybe we can contact via email? 2017-10-03 12 49 26

sergeyromanovsky avatar Oct 03 '17 10:10 sergeyromanovsky

@sergeyromanovsky I was trying to do the pagination just in the days. A little help for your problem (Base Classes, Pagination, hoverPause): https://jsfiddle.net/tufzuwy6/

jablonczay avatar Oct 03 '17 20:10 jablonczay

Man, u are the best !!!!

2017-10-03 23:18 GMT+03:00 Sándor Jablonczay [email protected]:

@sergeyromanovsky https://github.com/sergeyromanovsky I was trying to do the pagination just in the days. A little help for your problem (Base Classes, Pagination, hoverPause): https://jsfiddle.net/tufzuwy6/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pawelgrzybek/siema/issues/92#issuecomment-333965595, or mute the thread https://github.com/notifications/unsubscribe-auth/AUr9DXLMs4V38JMvjagsugTJXmaUpcghks5sopaugaJpZM4Pr2JS .

sergeyromanovsky avatar Oct 04 '17 13:10 sergeyromanovsky

I'm glad it helped! Here is the previous version extending with autoHeight: https://jsfiddle.net/yhmgqmf6/

jablonczay avatar Oct 05 '17 09:10 jablonczay

Hi, first big thx for your great plugin! Second, when will you integrate the autoHeight feature?

Overpowered avatar Apr 02 '18 12:04 Overpowered

Baking autoHeight into core would be really nice.

tommymarshall avatar May 21 '18 12:05 tommymarshall

I'm glad it helped! Here is the previous version extending with autoHeight: https://jsfiddle.net/yhmgqmf6/

Thank you so much for that!

manuelkling avatar May 17 '22 14:05 manuelkling