django-appsettings
django-appsettings copied to clipboard
pawamoy
Deprecate transform_default
I don't really see the point in the transform_default argument. It seems quite straightforward to provide the default value the same way it should be set up in settings. I'm in favor of deprecating the transform_default and eventually removing it and transform the default in all cases.
It was useful when providing a callable as default, and actually calling it to get the default value at runtime, though if nobody's using I'm OK to deprecate it.
The idea is to transform the default always, unless the call_default is True. I intent to keep the possibility of a callable default.
Ah yes, I forgot that. Then it was useful when you wanted to transform the value returned by the callable as well haha. But then the callable could indeed directly return the final value, so it's not that useful.
I'm okay with that, but it should be noted that transform_default is currently False by default and you are proposing to change it to True, which means it's a breaking change and it should be noted in the changelog and preferably even in release notes.
