RxIAPv3 icon indicating copy to clipboard operation
RxIAPv3 copied to clipboard

Migrating to rxjava2

Open jakubvimn opened this issue 8 years ago • 5 comments

This PR updates RxJava to version 2.x I cannot guarantee that it work (no unit tests to confirm that :( ), but if there are no null values passed to Observables, it should without any problems.

jakubvimn avatar Dec 15 '16 13:12 jakubvimn

Great work once again! Although this is a breaking change. I will probably need to host 2 different versions of the library! Will keep it open until I decide on what branching model I should follow. Any thoughts on this?

pavlospt avatar Dec 15 '16 13:12 pavlospt

There are some libraries that have different branches for different RxJava versions, like RxAndroid, but such approach requires more work for maintenance. Cutting off all the clients using RxJava1 may not be a good choice either. Maybe to best option would be using this library https://github.com/akarnokd/RxJava2Interop for backward compatibility. There are 2 options with it:

  • supporting only RxJava2 and pointing this library in README to give hope for RxJava1 users
  • using RxJava2 in the library but creating another module wrapping it with RxJava1 interface.

jakubvimn avatar Dec 15 '16 13:12 jakubvimn

Yeap, that seems right, I guess I will just create another branch then and follow that strategy. Will update you tomorrow :)

pavlospt avatar Dec 15 '16 14:12 pavlospt

Any update on this?

d4rken avatar Feb 02 '17 11:02 d4rken

@d4rken Hello, none yet, did not find the time to deal with it!

pavlospt avatar Feb 02 '17 12:02 pavlospt