Pavel Tomin
Pavel Tomin
@herve-gross abandon?
@MelReyCG any update?
@frankfeifan move into merge queue?
> > @frankfeifan move into merge queue? > > I will have to merge the develop and rebaseline the tests, and then we can move it to merge queue. thanks,...
please double check that logic is consistent with useMass flag (default is 0)
> please double check that logic is consistent with useMass flag (default is 0) and time step chop
> About `useMass`, the `checkMultiPhaseFluxStatistics` simulation does not converge anymore when I set it to 1. I am probably missing how to manage this component. Are the `SourceFlux` units in...
> Timestep cuts were tested by the `checkMultiPhaseFluxStatistics` test (this simulation has 3 sub-timesteps). I added a guard (`testInputs.requireSubTimeStep`) so it will keep being tested with timesteps. You test one...
> I've added the CSV export and try to make the code of `SourceFluxStatsAggregator::WrappedStats::gatherTimeStepStats()` clearer. Do you think this method is missing something about timestep cuts? Or do you think...
> > Would you mind adding that output into one of the xmls? > > Which XMLs output are you talking about ? I mean add this new SourceFluxStatistics output...