Pavel Feldman

Results 448 comments of Pavel Feldman

Thanks for another useful use case. I meant to ask a while ago, would you be interested in contributing patches for the components story?

> I'm somewhat limited in time, but I'd love to! How would you like to proceed? @[sand4rt](https://github.com/sand4rt) I'm adding unmount in the PR above, you can follow the pattern and...

> Wondering why you would choose for ({ unmount }) => {} and unmount(compoment) instead of just calling component.unmount()? The last option is easier to write and read. There is...

> We now have feature requests for the following functions and i think a few more will follow. Assuming it will be a breaking change, why not release it sooner...

What's your use case for the method? (Helps us prioritize)

@VaasRamsay ```js // playwright/index.ts import { beforeMount } from '@playwright/experimental-ct-react/hooks'; import { createServer } from "miragejs" beforeMount(async ({ hooksConfig }) => { createServer({ routes() { this.get("/api/users", () => hooksConfig.users) },...

@VaasRamsay would you be open to contributing a docs page (markdown) providing this example?

Closing with https://github.com/microsoft/playwright/pull/16706, thanks!

When we simply migrate users from one syntax to another, we don't really add much value. With Playwright, you are not supposed to use any of the suggested methods, you...

Did you enable `fullyParallel` in your config? That would make all these bars green all the time.