yaspin icon indicating copy to clipboard operation
yaspin copied to clipboard

Published 20 hours ago • verified publisher icon pavdmyt

Windows support

Open pavdmyt opened this issue 5 years ago • 6 comments

In continuation to discussion on windows support for yaspin started in #32

Minimum plan towards Windows support:

  • apply the patch for handling signals
  • use vistir/cursor module for cursor support
  • implement (or find the replacement for) termcolor features in Windows environment
  • unittests for all yaspin features under Windows
  • CI pipeline for tests under Windows

pavdmyt avatar Apr 04 '19 19:04 pavdmyt

  • It is definitely possible to retain the current API using colorama, I preserved the API for use in vistir with a wrapper and some tweaks to the implementation, so it shouldn't be a problem at all

techalchemy avatar Apr 08 '19 03:04 techalchemy

Related: #24

pavdmyt avatar Feb 26 '21 09:02 pavdmyt

pipenv is currently getting new wind. I am currently helping to maintain pipenv, and I would be happy if we could upstream pipenv`s patches to yaspin. Would we be able to do so? Is there any way we can help you with the adoption of these patches? @pavdmyt @matteius

oz123 avatar Apr 23 '22 21:04 oz123

Hi @oz123

What are these patches about? Generally, I'm open for the new PRs.

pavdmyt avatar Apr 25 '22 08:04 pavdmyt

This are patches that fix colors in Windows.

oz123 avatar Apr 25 '22 09:04 oz123

@oz123 yes, I'm open to improve Windows support. Feel free to submit PRs.

pavdmyt avatar May 04 '22 07:05 pavdmyt