jade-inheritance icon indicating copy to clipboard operation
jade-inheritance copied to clipboard

Can you update jade version?

Open crecotun opened this issue 8 years ago • 11 comments

Hi, current version of jade is 1.11. It includes feature 'block code support' and a lot of improvements. Can you update version in package.json?

crecotun avatar Feb 27 '16 07:02 crecotun

Hi @Krekotun. I think #13 would achieve that, where I've outlined some things we need to figure out first.

My understanding is that 1.11.0 has changes which aren't yet compatible with this project, so we can't just update to the latest version.

In #13 I mentioned that I'd like to allow consumers to be able to provide their own version of Jade so that they're not bound to any particular version beyond their control.

paulyoung avatar Feb 27 '16 22:02 paulyoung

@paulyoung it would be awesome to add some tests in repo, so you/consumer will see if new version of jade is breaking something.

I'd like to allow consumers to be able to provide their own version of Jade

Do you have any ideas how to make this?

crecotun avatar Feb 28 '16 05:02 crecotun

@Krekotun instead of:

var JadeInheritance = require('jade-inheritance');
var inheritance = new JadeInheritance('foo.jade');

something like:

var jade = require("jade");
var JadeInheritance = require('jade-inheritance');
var inheritance = new JadeInheritance(jade, 'foo.jade');

paulyoung avatar Mar 01 '16 19:03 paulyoung

@paulyoung nice, how soon do you plan to implements this?

crecotun avatar Mar 01 '16 20:03 crecotun

Huy guys, I use gulp-jade-inheritance but jade is used here differs from gulp-jade (1.11). I also want to use code blocks, like

- 
   var list = [
     ....
  ]

but jade 1.9 fails. How to solve it?

alex-shamshurin avatar Mar 10 '16 13:03 alex-shamshurin

I just updated package.json to "jade": "^1.11.0" and ran "npm -i" and code blocks now works.

alex-shamshurin avatar Mar 10 '16 13:03 alex-shamshurin

Is there an actual fix? I updated the version of Jade in our package.json but it is not working. Only way i found was to use npm-shrinkwrap.

boxman0617 avatar Apr 11 '16 20:04 boxman0617

Hmm, I changed nothing except the version and I have everything working.

alex-shamshurin avatar Apr 11 '16 21:04 alex-shamshurin

Having the same problem using "gulp-jade": "^1.1.0" as it is the last version. Getting error on jade code blocks like that

 -  
      var array = [    
        {
            title:'',
            content:''
         }
      ]

Error: unexpected text -\n src\test.jade\n at Object.Lexer.fail Tried to update to gulp-pug instead, but it didn't work out.

natrey avatar Apr 28 '16 13:04 natrey

The issue is with your package.json. Check it, it must work

alex-shamshurin avatar Apr 28 '16 17:04 alex-shamshurin

salex772, thanks! I changed the version of jade in jade-inheritance as you recommended here issue 14 and it works now!

natrey avatar Apr 29 '16 09:04 natrey