Vim-PHP-Stuff icon indicating copy to clipboard operation
Vim-PHP-Stuff copied to clipboard

Published 20 hours ago • verified publisher icon paulyg

Perhaps backslash too much

Open mnauta opened this issue 12 years ago • 2 comments

Line 610 reads: syn sync match phpRegionSync grouphere phpRegion "function\s.(.$"

I don't understand why there is a backslash in front of the dollar sign at the end. Wouldn't it make more sense to leave that backslash out? Removing the backslash at least solves my highlighting problems.

mnauta avatar Sep 07 '13 10:09 mnauta

I'm going to commit this as it doesn't seem to negatively impact anything for me. Just curious what issues it caused for you and what Vim version you are on.

paulyg avatar Sep 10 '13 03:09 paulyg

Hi,

The issue I had was that highlighting was sometimes missing for files I had visited before so that they opened in the middle of the file. This occurs since I installed "the ultimate Vim distribution" from vim.spf13.com. As you probably know, your plugin is incorporated in the PIV plugin which is one of the many plugins installed by that "Vim distribution". Because of the erratic nature of the problem, I picked one specific file where I looked at one specific method that reproducibly failed to highlight correctly upon opening of the file. For this specific case I could fix the highlighting problem by removing the backslash on line 610, and I also thought it made sense although I hardly know anything about Vim script. So that is when I added my remark on github.

However, I should have investigated a bit more, because the lack of highlighting still troubles me in other php files. So my suggested fix is not the solution of the problem, it just happened to work in one particular case. So I am not sure it is worth committing, it might make things worse for others. It would be good to investigate further why highlighting is sometimes off, but the "ultimate Vim distribution" installs and configures so many plugins that I find it hard to find the cause of things.

Regards,

Michiel Nauta

On 09/10/2013 05:08 AM, Paul Garvin wrote:

I'm going to commit this as it doesn't seem to negatively impact anything for me. Just curious what issues it caused for you and what Vim version you are on.

Reply to this email directly or view it on GitHub: https://github.com/paulyg/Vim-PHP-Stuff/issues/7#issuecomment-24130818

mnauta avatar Sep 10 '13 19:09 mnauta