Paul Mackerras

Since the patch is not trivial I will need a Signed-off-by line from the author of the patch.

What do the logs look like when it works (e.g. with ppp-2.4.8)?

Just ignoring EINVAL isn't the right thing to do; if the channel is already connected to an interface, how do we know that's the interface we want? And how did...

pcompression and accompression operate at a lower level than VJ compression and are not related to it.

> But I can't see any way of printing this out? > Is it a feature waiting to be implemented? Looks like it is. I added that back in 1998,...

This changed when chap.c got replaced by chap-new.c. There is a message printed in auth_withpeer_success() (auth.c): notice("%s authentication succeeded", prot); So it should log "CHAP authentication succeeded" at level LOG_NOTICE....

OK fair enough. I think the logging should be added in auth_peer_success() rather than chap_handle_response() though.

> I've explained why retransmitting is a bad idea here: [#87 (comment)](https://github.com/paulusmack/ppp/issues/87#issuecomment-595794742) > > This is a challenge/response authentication method and it is normal for the entire PPP session to...

What did you expect to happen, that didn't? With the 'passive' and 'silent' options, pppd will just sit there waiting to receive something from the other end, without sending anything...

As to why we have slprintf still, the main reason is that it has some useful formats that the standard C *printf functions don't have, for example, %I (IP address),...