Pavlo Tsimura

Results 138 comments of Pavlo Tsimura

The [proposal](https://github.com/Expensify/App/issues/48167#issuecomment-2315216449) by @NJ-2020 looks good to me. We use the same check here: https://github.com/Expensify/App/blob/a2645b505a0e8c05b6efc67d9d00b8edc5400c82/src/pages/workspace/WorkspaceInitialPage.tsx#L220 **πŸŽ€πŸ‘€πŸŽ€ C+ reviewed**

@Nodebrute we use `errors: {}` as a default value in other places related to banking: https://github.com/Expensify/App/blob/7dae918fa165f583e5818f1dc4fa690bf54b99c1/src/pages/EnablePayments/AdditionalDetailsStep.tsx#L33 https://github.com/Expensify/App/blob/8510c65be84612c6c848ec9d339071071bbc7503/src/pages/EnablePayments/OnfidoPrivacy.tsx#L26 IMO, we should stick to it and fix the RBR handling as in...

Deployed to production: https://github.com/Expensify/App/pull/48231#issuecomment-2325378456 Payment is due on **Sep 10**

- The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/33280 - The offending PR has been commented on, pointing out the bug it caused and...

Thanks for the proposals. @mkzie2's [proposal](https://github.com/Expensify/App/issues/47904#issuecomment-2306837701) was the first to include the access check inside the functions, which is vital for this case. Therefore, we should proceed with it. **πŸŽ€πŸ‘€πŸŽ€...

Deployed to production: https://github.com/Expensify/App/pull/48256#issuecomment-2325378563 Payment is due on **Sep 10**.

- The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/46617 - The offending PR has been commented on, pointing out the bug it caused and...

The [proposal](https://github.com/Expensify/App/issues/53838#issuecomment-2531831593) by @Tony-MK does the job. However, I wonder if it should be fixed on the BE. While tracking an expense in self-DM, we correctly set the optimistic `report.lastVisibleActionCreated`...

> Is that a BE thing that I can fix here too? No, it's an FE thing – the logic for marking the chat unread is to find the last...