abcjs icon indicating copy to clipboard operation
abcjs copied to clipboard

Difference between editor and display rendering on thesession.org

Open u38cg opened this issue 2 years ago • 6 comments

When I enter the below ABC in an editor window in thesession.org, the volta brackets display correctly. However, when the edit is saved the display truncates the bracket at the end of the line.

The editor behaviour can be seen at https://thesession.org/tunes/editor - I don't have a live example of the display behaviour as it's been edited by the maintainer since.

ABC:

|:f2 | AddA dddA | defd edBA | GggA ffAe |[1eBcB A2f2 | AddA dddA | defd edBA | gGBg fAdf | eddc d2 :| |:fg | aAff AddA | ffAf fAdd | GggA ffAe | [2 eBcB A2 fg | aAff AddA | ffAf fAdd | gGBg fAdf | eddc d2 :|

u38cg avatar Nov 17 '22 11:11 u38cg

I would love to figure out what is going on here - but I need to see it. I don't want to randomly save something to thesession though, so I don't know what I can do.

I'm guessing that the surrounding element has a fixed width that is a little too narrow.

paulrosen avatar Nov 26 '22 01:11 paulrosen

Sorry, this reply slipped past me! You don't have to save - if you go through the steps to add a tune you can see the issue on the final preview before you press save. I noticed it again the other day on another tune I submitted, FWIW

On Sat, 26 Nov 2022 at 01:58, Paul Rosen @.***> wrote:

I would love to figure out what is going on here - but I need to see it. I don't want to randomly save something to thesession though, so I don't know what I can do.

I'm guessing that the surrounding element has a fixed width that is a little too narrow.

— Reply to this email directly, view it on GitHub https://github.com/paulrosen/abcjs/issues/853#issuecomment-1327957552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENEMAHLHZUMMQSJYYULOKTWKFVE5ANCNFSM6AAAAAASDJLFJE . You are receiving this because you authored the thread.Message ID: @.***>

u38cg avatar Feb 13 '23 13:02 u38cg

I just looked closely at the music you posted above and I don't understand what you are trying to do. You have a first ending in the first part but no corresponding second ending. And a second ending the second part with no corresponding first ending.

paulrosen avatar Mar 05 '23 22:03 paulrosen

Sorry, had the 1s and 2s the wrong way round!

This is a common pattern in Scottish trad where the second time ending of the second part is a chunk of the first part - so you play (adjusting for pickups) lines 1, 2, 1, 2, 3, 4, 3, 2.

|:f2 | AddA dddA | defd edBA | GggA ffAe |[2 eBcB A2f2 | AddA dddA | defd edBA | gGBg fAdf | eddc d2 :| |:fg | aAff AddA | ffAf fAdd | GggA ffAe | [1 eBcB A2 fg | aAff AddA | ffAf fAdd | gGBg fAdf | eddc d2 :|

On Sun, 5 Mar 2023 at 22:02, Paul Rosen @.***> wrote:

I just looked closely at the music you posted above and I don't understand what you are trying to do. You have a first ending in the first part but no corresponding second ending. And a second ending the second part with no corresponding first ending.

— Reply to this email directly, view it on GitHub https://github.com/paulrosen/abcjs/issues/853#issuecomment-1455220405, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENEMAE5BAQD6CXKVNW5FDLW2UEQ7ANCNFSM6AAAAAASDJLFJE . You are receiving this because you authored the thread.Message ID: @.***>

u38cg avatar Mar 09 '23 21:03 u38cg

So, if you were to write this out with the repeats explicit, this is how it should sound?

f2 | AddA dddA | defd edBA | GggA ffAe | eBcB A2f2 |
AddA dddA | defd edBA | gGBg fAdf | eddc d2 :|
fg | aAff AddA | ffAf fAdd | GggA ffAe | eBcB A2 fg |
aAff AddA | ffAf fAdd | gGBg fAdf | eddc d2 fg | 
aAff AddA | ffAf fAdd | GggA ffAe | eBcB A2f2 |
AddA dddA | defd edBA | gGBg fAdf | eddc d2 |]

Sorry to be slow about this, but I don't know how I would get the midi player to understand the pattern. I'm only understanding the pattern from your additional comment. I'd never have gotten it from the music.

paulrosen avatar Mar 14 '23 19:03 paulrosen

Yes, that's it exactly!

On Tue, 14 Mar 2023 at 19:56, Paul Rosen @.***> wrote:

So, if you were to write this out with the repeats explicit, this is how it should sound?

f2 | AddA dddA | defd edBA | GggA ffAe | eBcB A2f2 | AddA dddA | defd edBA | gGBg fAdf | eddc d2 :| fg | aAff AddA | ffAf fAdd | GggA ffAe | eBcB A2 fg | aAff AddA | ffAf fAdd | gGBg fAdf | eddc d2 fg | aAff AddA | ffAf fAdd | GggA ffAe | eBcB A2f2 | AddA dddA | defd edBA | gGBg fAdf | eddc d2 |]

— Reply to this email directly, view it on GitHub https://github.com/paulrosen/abcjs/issues/853#issuecomment-1468736894, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENEMAFM7G5C5OHYK2E426DW4DEQLANCNFSM6AAAAAASDJLFJE . You are receiving this because you authored the thread.Message ID: @.***>

u38cg avatar Mar 14 '23 22:03 u38cg