Paul Robert Lloyd
Paul Robert Lloyd
Ah, now that you bring the `--no-border` modifiers into it… In 3f339a8, I’ve changed this so that we only remove the bottom margin on the last child of the last...
Out of interest, how is this breaking? At a guess, markup is changed due to introduction of the wrapper?
@anandamaryon1 Added summary card to the list of missing components (although it’s a sorta sub-component).
> And, think I've found a styling bug, which applies to the gov version too. When `disabled` the focus styles are applied if you click on the label. If you...
Have rebased `main` and tidied up the commits (would be lovely to have a least one PR added without hundreds of back-and-forth commits, grumble grumble).
Hi @sarawilcox. The main challenge with using guidance for this component from the equivalent on the GOV.UK Design System is that they have the original component with guidance on how...
@colinrotherham Can we also show focused (and file picked) states for the File upload component on the form control states page?
@anandamaryon1 JSDOM unit and Puppeteer behaviour tests added, and SonarQube code quality issues resolved. Beyond any last-minute design changes, this should be ready to merge.
Love it! But also a little torn as I know my team will be using the GOV.UK components gem, so these differences will need a little massaging. I wonder if...
> How's it looking with this old issue in mind? Haven’t tested (not sure I can test given the environment mentioned in that thread), but not sure it should occur...