xkcd icon indicating copy to clipboard operation
xkcd copied to clipboard

Published 20 hours ago • verified publisher icon paulrehkugler

Localize

Open josharian opened this issue 11 years ago • 5 comments

One user has offered to provide a Japanese translation. I suspect that there would be other volunteers if called for.

The initial bout of work here, then, is making sure all strings/nibs/etc. are appropriately localized (instead of hard-coding English), and extracting a strings file.

Probably not high priority, given that the comics are in English, so comfort with English is a prerequisite to enjoying the app at all.

josharian avatar Jun 04 '13 16:06 josharian

Gotcha. It makes sense to do this anyway: in case any changes to the app language are needed, everything will be consolidated ate easy to find without much digging.

paulrehkugler avatar Jun 04 '13 16:06 paulrehkugler

I have a branch for this on my fork; it's tested and ready, but I want to wait for my other pull request to be accepted so everything is in bite-sized chunks.

paulrehkugler avatar Sep 29 '13 19:09 paulrehkugler

Great! And yeah, makes sense; best to keep these things nice and atomic, and our two master branches have diverged a bit. It'll be good to get them back into sync, and then (ideally) start using feature branches for stuff like this.

josharian avatar Sep 29 '13 22:09 josharian

I'll clean up my repo and give you the localization PR soon. Do you want to make a branch for me to submit a PR to until you get the Japanese translations or to submit a pull request to master?

paulrehkugler avatar Oct 01 '13 01:10 paulrehkugler

Go ahead and submit a pull request to master.

josharian avatar Oct 01 '13 01:10 josharian