qtpdfium icon indicating copy to clipboard operation
qtpdfium copied to clipboard

Visual C++ 14 can no longer build since upgrade of pdfium

Open redturtlepower opened this issue 6 years ago • 2 comments

The commit b69b17b does not compile on my Windows 8.1 machine, with MSVC 14 (it is the only commit I have tested).

Seems to be the same issue that Pinaraf had last year:

fx_memory.h: C2065: noinline undeclared identifier C4430: missing type specifier C3861: FX_OutOfMemoryTerminate identifier not found C2448: attribute function-style initializer appears to be a specific function definition

fx_stream.h: C1083: Cannot open include file: 'dirent.h'. No such file or directory

I have opened the project file in QtCreator and tried to run the 'cpp' target.

redturtlepower avatar Jul 17 '18 23:07 redturtlepower

Hi @redturtlepower! Unfortunately, I don't have a Windows machine to test it out, it would be lovely to get a patch for that issue you are facing.

paulovap avatar Jul 19 '18 12:07 paulovap

After some analysis I can tell that the macro '&& defined (Q_CC_MSVC)' does not work. I needed to manually define it in the top level pri file, and this is certainly not intended. You could perhaps instead #include <qglobal.h> somewhere. Moreover you seem to be missing the #include <windows.h> for HANDLE and so on...

redturtlepower avatar Jul 22 '18 08:07 redturtlepower